mgr: fix UpdateActiveMgrLabel to retry label update on failure #14160
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkachach
changed the title
travisn
requested changes
May 6, 2024
fix UpdateActiveMgrLabel to retry label update on failure. Previously, the function always returned the current manager, even if update failed, leading to inconsistent labels. This fix ensures retries on failures. Fixes: rook#13601 Signed-off-by: Redouane Kachach <[email protected]>
travisn
approved these changes
May 6, 2024
This was referenced May 6, 2024
travisn
added a commit
that referenced
this pull request
May 6, 2024
mgr: fix UpdateActiveMgrLabel to retry label update on failure (backport #14160)
travisn
added a commit
that referenced
this pull request
May 6, 2024
mgr: fix UpdateActiveMgrLabel to retry label update on failure (backport #14160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UpdateActiveMgrLabel to retry label update on failure. Previously, the function always returned the current manager, even if update failed, leading to inconsistent labels. This fix ensures retries on failures.
Fixes: #13601
Checklist: