[Bug]: maskInputFn is not called on inputs

[ericmeadows]

Preflight Checklist

• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb-snapshot

Version

v1.1.3

Expected Behavior

I have created a maskInputFn, which should print the element, as well as ignore hidden elements...

Actual Behavior

No console logs appear, and the hidden fields come through, unmasked..

Steps to Reproduce

I have created a maskInputFn, which I would assume would sanitize my inputs, but the data is coming through...

Here's maskInputFn:

  function maskInputFn(text, element) {
    console.log("element", element);
    if (element.type === "hidden") {
      return "";
    }
    // Default to returning the original text
    return text;
  }

Here's the initialization:

rrwebRecord({
  emit(event) {
    console.log("emitting");
    cacheEvents(event);
  },
  maskInputOptions: { maskInputFn },
  maskInputFn
});

Testcase Gist URL

No response

Additional Information

This is extremely important for us to handle...

[chetan-187]

Let me have a look at it

[chetan-187]

@ericmeadows You are passing wrong value in maskInputOptions, it accepts an object with following keys with boolean values.

{
color: boolean;
date: boolean;
'datetime-local': boolean;
email: boolean;
month: boolean;
number: boolean;
range: boolean;
search: boolean;
tel: boolean;
text: boolean;
time: boolean;
url: boolean;
week: boolean;
textarea: boolean;
select: boolean;
password: boolean;
}

You are passing your function in maskInputOptions.

If you want your function to work, you need to pass which of above keys you want to ignore. I think that's not the correct implementation.

Correct implementation should be, if you are passing maskInputFn every input should go through that function regardless of the maskInputOptions.

Any thoughts?