-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*.video* -> *.mp4 #31
Comments
We'll create three branches using |
id assume ffmpeg will always be faster since you wont need to |
ffmpeg is the tool that would be used to transform the video format from any video format (excluding mp4) to mp4. The comparison states to use 1 of three methods, local computation, raw local computation, and an external API. The fallback of the API is that it might be rate-limiting either the hosting-providers internet bandwidth or the API usage rate (like how many times you can use it in x time). The advantage of using the API would confirm an approximate constant speed of delivery since the API uses more optimized or faster computer hardware, where as the hosting provider's hardware won't be as optimized or as fast. Upload size would also be similarly consistent since Discord provides a smaller upload size of 8 Mb for default users (this is an advantage because there are more non-nitro users than nitro users). |
bro wrote a whole essay dawg i know what ffmpeg is im just saying that in terms of steps to do what u wanna do using ffmpeg directly would be faster but maybe using their API would be more consistent and "known" outcome yep Gg |
gg |
WTF!!1 |
RIP. |
imo id remove ffmpeg with exec from consideration cause people may find sussy exploits with exec |
I mean maybe, all it does is download the file and put it through ffmpeg, the exec part would just be the downloaded file name and again we can just rename or sanitize it. |
dont download untrusted files idiot |
could containerize the process |
wasm is also sandboxed so if you use ffmpeg wasm you'd also probably be fine |
O_O |
changes x video format files to mp4 so it can be previewable in discord, this would either use ffmpeg, ffmpeg js, or an api.
make inline reply, file upload, and file link as args.
The text was updated successfully, but these errors were encountered: