Bookmarking bug: only the last setBookmarkExclude() is honoured, all previous excludes are ignored

[daattali]

When calling setBookmarkExclude() multiple times, only the last call actually excludes the given inputs.

Example: There are 4 inputs in the app below, which are being excluded in two separate calls. When the bookmark button is clicked, the excluded inputs are printed, and you can see it's only the inputs from the last call.

library(shiny)

ui <- function(req) {
  fluidPage(
    bookmarkButton(),
    textInput("test1", "test1", "test1"),
    textInput("test2", "test2", "test2"),
    textInput("test3", "test3", "test3"),
    textInput("test4", "test4", "test4")
  )
}

server <- function(input, output, session) {
  setBookmarkExclude(c("test1", "test2"))
  setBookmarkExclude(c("test3", "test4"))
  
  onBookmark(function(state) {
    message(state$exclude)
  })
}

shinyApp(ui, server, enableBookmarking = "url")

I think it's because in this line the excluded inputs are being assigned/overrided instead of appended to a list. Is there a reason they can't be appended instead of overridden?

[jcheng5]

This has caught me out as well. I think for now we'd need to use an add = TRUE like on.exit, but here's another case for shiny editions to let us change the default behavior in the future...

[jcheng5]

LOL, dupe of your own issue #2323

[daattali]

Whoops :p My github issue searching skills are much weaker than my googling skills....