Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit-clone: PartialEq not impl'd for &Ty #10019

Closed
matthiaskrgr opened this issue Dec 1, 2022 · 0 comments · Fixed by #10022
Closed

implicit-clone: PartialEq not impl'd for &Ty #10019

matthiaskrgr opened this issue Dec 1, 2022 · 0 comments · Fixed by #10022
Labels
C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied

Comments

@matthiaskrgr
Copy link
Member

Summary

.

Lint Name

implicit-clone

Reproducer

I tried this code:

fn main() {
    let x = &Baz;
    let y = &Baz;

    y.to_owned() == *x;
}

#[derive(PartialEq)]
struct Baz;

impl ToOwned for Baz {
    type Owned = Baz;
    fn to_owned(&self) -> Baz {
        Baz
    }
}

I saw this happen:

This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You're likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/rust/issues
quoting the full output of this command we'd be very appreciative!
Note that you may be able to make some more progress in the near-term
fixing code with the `--broken-code` flag

The following errors were reported:
error[E0277]: can't compare `&Baz` with `Baz`
 --> src/main.rs:5:23
  |
5 |     let _ = y.clone() == *x;
  |                       ^^ no implementation for `&Baz == Baz`
  |
  = help: the trait `std::cmp::PartialEq<Baz>` is not implemented for `&Baz`
  = help: the trait `std::cmp::PartialEq` is implemented for `Baz`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
Original diagnostics will follow.

warning: implicitly cloning a `Baz` by calling `to_owned` on its dereferenced type
 --> src/main.rs:5:5
  |
5 |     y.to_owned() == *x;
  |     ^^^^^^^^^^^^ help: consider using: `y.clone()`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
  = note: requested on the command line with `-W clippy::implicit-clone`

Version

rustc 1.67.0-nightly (c97b539e4 2022-11-30)
binary: rustc
commit-hash: c97b539e408ea353f4fde2f9251d598291fec421
commit-date: 2022-11-30
host: x86_64-unknown-linux-gnu
release: 1.67.0-nightly
LLVM version: 15.0.4

Additional Labels

No response

@matthiaskrgr matthiaskrgr added C-bug Category: Clippy is not doing the correct thing I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied I-false-positive Issue: The lint was triggered on code it shouldn't have labels Dec 1, 2022
@bors bors closed this as completed in 38fce12 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have I-suggestion-causes-error Issue: The suggestions provided by this Lint cause an ICE/error when applied
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant