Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation matrix handedness #512

Open
hayashi-stl opened this issue Aug 8, 2020 · 2 comments
Open

Rotation matrix handedness #512

hayashi-stl opened this issue Aug 8, 2020 · 2 comments

Comments

@hayashi-stl
Copy link
Contributor

Looking at the documentation for Basis2, it claims to be a rotation matrix. However, the guarantee is that it's orthogonal, which is not enough for a rotation matrix. The determinant has to be 1. In fact, Basis2::look_at_stable can create a reflection matrix. Should reflection matrices be allowed in Basis2 or should the hole in Basis2::look_at_stable be fixed and the documentation updated to say that Basis2 is guaranteed to be orthogonal and have a determinant of 1?
@kvark
Copy link
Collaborator

kvark commented Aug 9, 2020

Did you see #508 that is deprecating look_at?

@hayashi-stl
Copy link
Contributor Author

Okay, I'll wait and see if the replacement can still produce reflection matrices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @hayashi-stl