Sink doesn't fail on 403, and other non-success codes

[jamesbascle]

In the EmitBatchAsync method in LogglySink.cs, there is nothing that I could find that will cause the exception on line 42 to actually be caught, since HttpClient does not throw by default.

Perhaps we could change it to

var result = await httpClient.PostAsync(_logglyUrl, content);
result.EnsureSuccessStatusCode();

To force an exception on non-success result codes? I noticed this while writing a local test and intentionally putting the wrong CustomerToken in, I did not get any output to Trace or Serilog.Debugging.SelfLog as I would expect on a 403.

Open to other fixes as well.

[samirahmed]

@jamesbascle if you could submit a PR this would be great

[samirahmed]

additionally i don't own a PC anymore so I can't really do anything with this code... sooooooo you might want to fork it make the changes and create your own nuget package.

[cmcewen]

I also have this issue and would appreciate immediate resolution

[crowell]

👍 I depend heavily on this framework

[nambrot]

Me too

[jamesbascle]

@samirahmed I have no problems taking over this thing...I'll fork and try to set up an Appveyor CI NuGet build this week. Will update this thread when done.

[jamesbascle]

Alright, I've got a CI build set up on AppVeyor, and it can push to NuGet.org. Currently have it set to Serilog.LogglyBulk. Would prefer to use the one @samirahmed set up if he can scrounge up the creds and XFer ownership/invite me as an Owner.

[samirahmedsc]

@jamesbascle what is your nuget.org username? i added a jamesbascle as owner ... hopefully that is you

[jamesbascle]

It is indeed, but I don't see anything that has changed on NuGet.org from my side. I'll try pushing to it using a -prerelease package with 0 functional changes.

[jamesbascle]

Hmm. I am still unable to view any ownership capabilities in the NuGet.org site, nor is AppVeyor able to push to that feed using my API key.

[jamesbascle]

For all following the thread, I've released a new version with the suggested changes at https://www.nuget.org/packages/Serilog.LogglyBulk/0.1.2.1

You can see the code on my fork of this repo. Hopefully we can work out the issues with the original NuGet.org feed, and the repo can be XFerred to me, otherwise I'll maintain my fork and feed if any new issues come up.