Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Allow OPs to change skins of offline players #87

Open
NoThrottle opened this issue Jan 8, 2024 · 6 comments
Open

[Suggestion] Allow OPs to change skins of offline players #87

NoThrottle opened this issue Jan 8, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@NoThrottle
Copy link

My 1.20.1 server has events where skins with a theme is a necessity. Being able to change all players' skin via the console even if they are offline would be great.

I already tried modifying the 1.20.1 source code here to allow using a UUID input or a username input then getting the UUID MD5 hash but alas, my lack of experience in modding became an obstacle.

@samolego
Copy link
Owner

samolego commented Jan 8, 2024

Hum that's actually a cool idea, thanks for suggesting. Rn development is kinda stuck at "just porting, no new features", but I might add it when I revisit the project.

Though if you manage it, I'll be glad if you open a PR ;).

@samolego samolego added the enhancement New feature or request label Mar 4, 2024
@RedBed24
Copy link

You can use /execute as <offline player> run skin ...

@samolego
Copy link
Owner

Wait, that works for offline players as well?

@RedBed24
Copy link

RedBed24 commented Apr 3, 2024

I've checked some cases, here's what I found:

  • When in a offline server without fabric tailor, the skin can't be changed, not even in client side.
  • When in a offline server with fabric tailor, a moderator can change the skin of an offline player and an online player. Even when none of the players has fabric tailor installed.

So having fabric tailor installed in the server, even if it allows offline players, skins can be changed for everyone. Any moderator can use /execute as <player> run skin ... to change anyone's skin, even for offline players.

I haven't tested using the upload skin function, the cases where done using the player subcommand, but I assume this will also work, even if the server is in a network without internet access.

@samolego
Copy link
Owner

samolego commented Apr 3, 2024

You're talking about online-mode=false, which is irrelevant, as OP suggested changing skins for disconnected players.

@RedBed24
Copy link

RedBed24 commented Apr 3, 2024

Ohh, I see, sorry, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants