Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Warn about internet conection on /skin set #95

Open
Apis035 opened this issue Mar 2, 2024 · 7 comments
Open

[Feature] Warn about internet conection on /skin set #95

Apis035 opened this issue Mar 2, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Apis035
Copy link

Apis035 commented Mar 2, 2024

Minecraft 1.20.4
Fabric Tailor 2.3.0

Upon entering this command with no internet connection, it will respond with:

Trying to set the skin ... Please wait.
Uploading skin. Please wait.
You have to provide URL, player's name or file of the skin you want.

Does work fine when having internet connection.

I'm playing on a local LAN with friends with no internet connection, using this mod to set our skins.

@Apis035 Apis035 added the bug Something isn't working label Mar 2, 2024
@samolego
Copy link
Owner

samolego commented Mar 2, 2024

This mod doesn't change skin fetching mechanic, it still uses mojang's system. So it needs internet access.

@Apis035
Copy link
Author

Apis035 commented Mar 3, 2024

Ooh, I thought it wasn't supposed to be like that because of the respond message. It also delayed few seconds before displaying "You have to provide URL, player's name or file of the skin you want." like it is actually doing something. 🤔

Maybe change the error message to indicate that this mod doesn't work without internet connection?

@samolego
Copy link
Owner

samolego commented Mar 3, 2024

It's doing something but fails to do it ... error mesaage is pretty generic, yeah.
Probably shows some info in logs?

@Apis035
Copy link
Author

Apis035 commented Mar 4, 2024

Yeah, that would be better

@samolego samolego added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels Mar 4, 2024
@samolego samolego changed the title [BUG] /skin set upload fails when no network connection [Feature] Warn about internet conection on /skin set Mar 4, 2024
@LegendaryMouse
Copy link

the error still pops up even with internet connection

@LegendaryMouse
Copy link

imgur and other servers show same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants