Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for upcoming Seurat v5 Release #131

Closed
Gesmira opened this issue Oct 3, 2023 · 3 comments
Closed

Prepare for upcoming Seurat v5 Release #131

Gesmira opened this issue Oct 3, 2023 · 3 comments

Comments

@Gesmira
Copy link

Gesmira commented Oct 3, 2023

Hi Sam,
Hope you're well! I am opening this issue as a notification because scCustomize is listed as a package that relies (depends/imports/suggests) on Seurat.

I know you are already aware we recently released Seurat v5 as a beta in March of this year. We are now preparing to release Seurat v5 to CRAN, and plan to submit it on October 23rd. While we have tried our best to keep things backward-compatible, it is possible that updates to Seurat and SeuratObject might break your existing functionality or tests. We wanted to reach out before the new version is on CRAN, so that there's time to report issues/incompatibilities and prepare you for any changes in your code base that might be necessary.

As a reminder, to test the upcoming release, you can install Seurat from the seurat5 branch using the instructions available on this page: https://satijalab.org/seurat/articles/install.

Thank you!
Seurat v5 team

@samuel-marsh
Copy link
Owner

Hi Seurat Team!

Thanks so much for the message. I've begun preparing for V5 release and have switched the active dev branch of scCustomize to "develop_V5" and have my worklist of items to check in this issue (#101). My plan for package to is to coordinate and also push v2.0.0 to CRAN on October 23rd (package will only depend on 4.3.0.1 so no issues in case Seurat's CRAN approval/check is slow).

Thus far in my use with my own analysis after updates in dev branch everything seems to be functioning correctly right now. The one major kick the tires tests I have to run (probably post SCG2023 next week) are running all the functionality through BPCells stored data as all my testing thus far is just with in memory objects as my current analysis is small enough to easy handle in memory.

I'll update in Seurat repo if I notice any further bugs during my testing. I'll leave this issue open and post here in case I have question related to bug in scCustomize and have question about properly interfacing with Seurat.

Thanks!!
Sam

@Gesmira
Copy link
Author

Gesmira commented Oct 3, 2023

Hi Sam,
Thanks, that's awesome to hear :)
We'd be very interested to know how the BPCells testing goes for you and, of course, let us know if you run into any other problems.
Best,
Gesi

@samuel-marsh
Copy link
Owner

Hi @Gesmira,

As of right now in my current dev branch (develop_V5) I have not found any issues in terms of compatibility with Seurat 5. I'm going to close this issue for now and work on finalizing scCustomize for a push to CRAN once Seurat 5 is approved and makes it way there.

Thanks!
Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants