-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document 1.63.0 breaking change / 1.63.3 doesn't seem to fix it #2011
Comments
thanks @noraj its working |
#2010 may fix the import but not the doc |
Thanks, @noraj ! |
Hi guys, the v1.63.x changes also broke the https://github.com/neomjs/neo theme-builder and -watcher. The required change is very similar to what @noraj did: As a workaround I had to change: -import sass from 'sass';
+import * as sass from 'sass'; Please document breaking changes inside the changelog or use new major versions or beta tags inside the versioning to highlight this. Thx! |
Breaking changes are when we intentionally make a change that is not compatible with earlier versions. In this particular case, the release did break things but it was unintentional. In other words, a bug. The bug was fixed in So instead, I think instead you are proposing that whenever there is a noteworthy bug in a release then the |
Assigning to @nex3 for additional input. |
my personal take on this issue is that the v1.63.3 does not fix it for me either, I guess that I will have to do the proposed workaround (not ideal though) -import sass from 'sass';
+import * as sass from 'sass'; because It is also the second time that this project releases breaking change under a It would be helpful and avoid less problems if this project could follow a stricter semver though I understand that it might sometime be hard to detect a breaking change. It ok to release major breaking change every now and then. this is my personal take on the subject, it's ok to disagree with me. Cheers and thanks for the great lib |
Duplicate of #2008 |
Since the breaking change wasn't intentional, the appropriate fix is to un-break it rather than document the breakage. |
In think both are needed. Else people can still unexpectedly update to a broken version. |
There are always going to be intermediate versions that are broken in one way or another. That's the nature of introducing and fixing bugs. |
While updating sass 1.62.1 → 1.63.2 I encounter the following error:
It seems that 1.63.0 is including a breaking change I don't see listed in the changelog or the release note.
Note: It's in an ESM file: https://gitlab.com/rawsec/rawsec-cybersecurity-list/-/blob/master/gulpfile.mjs#L8
I saw this message #1995 (comment) in #1995 but 1.63.1 and 1.63.2 don't seem to fix it.
1.66.3 (https://github.com/sass/dart-sass/pull/2006/files) claims to fix it.
However, I suggest updating 1.63.0 changelog to notify the breaking change bug and tell 1.63.3 release fix it so this bug is documented. Just having 1.63.3 release note saying it fixed a bug is not enough, because automatic dependency update bot will fetch release not, and when updating to 1.63.0 nothing in it says there is a breaking change.
I just tested 1.63.3 and I still have:
As a workaround I had to change:
So this is even more a breaking change that should be documented in the changelog as well as the import method syntax upgrade needed.
The text was updated successfully, but these errors were encountered: