Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when handling articles with no body #5

Open
kevingy opened this issue Aug 31, 2020 · 1 comment
Open

Crash when handling articles with no body #5

kevingy opened this issue Aug 31, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@kevingy
Copy link
Contributor

kevingy commented Aug 31, 2020

When there is a Usenet article with no body (that is, the entire message is the subject line only), the library crashes in OverAsync when processing the return from the server. Consider the "parts" for this article header:

image

When the number of lines ("parts[7]") is parsed into an int at line 624 of NttpClient.cs, an exception is thrown as string.Empty can not be parsed as an int value.

(I can submit a pull request to fix this issue.)

@seanmcelroy
Copy link
Owner

Thanks for report! I'd be happy to take a PR for this one, otherwise I'll get to it when I have a chance in a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants