Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable feature h3 in reqwest 0.12.5 adds breaking change: Sync implementation on return future is removed #2322

Open
Tracked by #2303
NobodyXu opened this issue Jun 18, 2024 · 1 comment · May be fixed by #2339
Open
Tracked by #2303
Labels
A-http3 Area: HTTP/3 E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.

Comments

@NobodyXu
Copy link
Contributor

With reqwest 0.12.5, if I enable the feature h3, then the Sync implementation on the returned future is removed.

While I know that h3 is an unstable feature, I think this is.a breaking change since adding new feature should not change return type (bound) of existing function, and the removal of Sync is a bit surprising given that it works without h3.

@seanmonstar
Copy link
Owner

Thanks for calling that out, it's not intentional. We could probably add some assert_sync::<ResponseFuture> test, and fix it for h3.

@seanmonstar seanmonstar added E-pr-welcome The feature is welcome to be added, instruction should be found in the issue. A-http3 Area: HTTP/3 labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http3 Area: HTTP/3 E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants