Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MALDIquantForeign generates and prints a warning for every spectrum when reading imzML #32

Open
AlanRace opened this issue Aug 13, 2021 · 1 comment

Comments

@AlanRace
Copy link

I have been evaluating multiple imzML parsers (see here https://imzml.github.io/) with publicly available imzML datasets (e.g. https://metaspace2020.eu/datasets?ds=2017-06-30_07h26m26s) and experienced some issues with MALDIquantForeign.

It seems that if a common 'error' is encountered for each spectrum, then this will flood the console with one message per spectrum (which for MSI Data is a lot!) eventually leading to a system crash. The error for the dataset linked above is given below. Perhaps it would be possible to just display the warning once per dataset, rather than per spectrum?

- Warning in .createMassObject(mass = mass, intensity = intensity, metaData = m, :
-    According to the metadata information the imported data are centroided, but they are treated as profile (MassSpectrum) data. Maybe you want to use 'centroided=TRUE'. See '?import' for details.
@sgibb
Copy link
Owner

sgibb commented Sep 8, 2021

I see your point. I could remove the immediate. argument but than it is not clear for which spectrum the warning was thrown. You are right that for imzML datasets a collected warning once per dataset would be more helpful but for other datasets every spectrum could contain different errors.

Does suppressWarnings(importImzMl(file)) works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants