-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gettime() rejects >ULONG_MAX (Reproducible Builds problem) #961
Comments
The third field in the /etc/shadow file (sp_lstchg) contains the date of the last password change expressed as the number of days since Jan 1, 1970. As this is a relative time, creating a user today will result in: username:17238:0:99999:7::: whilst creating the same user tomorrow will result in: username:17239:0:99999:7::: This has an impact for the Reproducible Builds[0] project where we aim to be independent of as many elements the build environment as possible, including the current date. This patch changes the behaviour to use the SOURCE_DATE_EPOCH[1] environment variable (instead of Jan 1, 1970) if valid. [0] https://reproducible-builds.org/ [1] https://reproducible-builds.org/specs/source-date-epoch/ Signed-off-by: Chris Lamb <[email protected]>
We're frozen for a release, due in a few days probably. After that, depending on the time @hallyn and @ikerexxe have for reviewing, I'll try to get this merged ASAP. That PR looks huge, but it's really overlapping several other smaller PRs, so it shouldn't be too hard to review, I think. I've divided it in similar chunks that are related (each branch is a PR):
which results in the following PRs:
Also, liba2i is already available at
I'm still working on the build system a little bit so I didn't say anything yet, but if you're interested in packaging that, please let me know if I can help. Just mind that the source code is stable and tested, but the build system is still unstable, so don't rely too much on it (but you're welcome to try it, so I can improve it). (BTW, @thesamesam , there's already a kernel.org git and a mailing list, so you can report your remaining concerns about it in the list) |
And if you're only interested in what changes gettime, it's just two commits:
|
I've opened this issue to track the problem, since comments on commits aren't easy to handle [@hallyn ].
Please keep the discussion here. It started in cb610d5#r136407772, so please read that, but don't write there.
Cc: @lamby
Cc: @pkitszel
The text was updated successfully, but these errors were encountered: