Add support for scanning inside Symfony's bundles.php

[ruudk]

In my Symfony Application, we have a config/bundles.php that looks like this:

<?php

declare(strict_types=1);

return [
    Symfonycasts\TailwindBundle\SymfonycastsTailwindBundle::class => ['all' => true],
    Symfony\UX\StimulusBundle\StimulusBundle::class => ['all' => true],
];

My configuration looks like this:

<?php

use ShipMonk\ComposerDependencyAnalyser\Config\Configuration;

$config = new Configuration();
$config->addPathToScan(__DIR__ . '/config/bundles.php', isDev: false);

return $config;

But even though those bundles are used, the analyzer complains:

$ vendor/bin/composer-dependency-analyser

Using config composer-dependency-analyser.php

Found unused dependencies!
(those are listed in composer.json, but no usage was found in scanned paths)

  • symfony/stimulus-bundle
  • symfonycasts/tailwind-bundle

Am I missing something, or is a FQCN class reference not seen as usage?

[janedbal]

Files without namespace and use statements have limited support as stated in readme. So just use FQN or use statements.

[ruudk]

@janedbal Hmm, interesting. When you have a bundles.php file with 50 bundles, having to import all them, makes the file 100+ lines instead of 50 lines. So I would prefer not to have to do that.

Would it be possible to improve this limited support?

[ruudk]

If it is, I could try to provide a PR for it.

[janedbal]

When you have a bundles.php file with 50 bundles, having to import all them, makes the file 100+ lines instead of 50 lines. So I would prefer not to have to do that.

So use FQN like this:

<?php

return [
    \Symfonycasts\TailwindBundle\SymfonycastsTailwindBundle::class => ['all' => true],
    \Symfony\UX\StimulusBundle\StimulusBundle::class => ['all' => true],
];

Would it be possible to improve this limited support?

Definitelly not easy. I'll try to think about that again.

[ruudk]

So use FQN like this:

<?php

return [
    \Symfonycasts\TailwindBundle\SymfonycastsTailwindBundle::class => ['all' => true],
    \Symfony\UX\StimulusBundle\StimulusBundle::class => ['all' => true],
];

That works, although PHPStorm / PHP CS Fixer now automatically imports it. Not ideal.

[janedbal]

Ok, I dived into it and turns out it was quite easy (#148).

Can you try dev-master if that works for you? Thanks

[ruudk]

@janedbal It works 🎉 ⚡ Thank you!!

[ruudk]

If you have time, it would be great to have it tagged too.

[janedbal]

Released as 1.6.0