Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some confusion about the inconsistency between code and paper description #29

Open
LiuHuijie6410 opened this issue Mar 20, 2024 · 3 comments

Comments

@LiuHuijie6410
Copy link

I appreciate your awesome work very much. However, there are some things I don't understand.
During the training process, each iteration has a 20% probability that mask_spatial_lora is True, and mask_temporal_lora is always False. If a certain lora is masked, the lora scale of this part will be set to 0. This does not freeze the lora, but cancels the lora. This is inconsistent with the dual channel mentioned in the paper. Is it because I didn’t understand the code?
thank you for your reply

@ruizhaocv
Copy link
Collaborator

Hi. This trick is just for faster training. You can simply set the probability to 0%.

@LiuHuijie6410
Copy link
Author

Hi. This trick is just for faster training. You can simply set the probability to 0%.

Sorry, maybe I didn't make it clear what I meant. I mean when training, if you want to freeze spatial lora, you set lora_i = 0. But I think this operation only bypasses lora, rather than freezing lora.

@LiuHuijie6410
Copy link
Author

Hi. This trick is just for faster training. You can simply set the probability to 0%.

Maybe I misunderstood the meaning of mask_temporal_lora and mask_spatial_lora. Could you please introduce these two variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants