-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComfyUI IPA: Failed to save graph file & Increased Time Consumption #869
Comments
Update version information:
Same error message: |
在显卡A30上测试发现,在set_model_patch_replace这个函数运行时,onediff重写后的运行时间比原本长,原本的时间为:0.0009s,使用onediff后运行时间为:1.04s,耗时增加了很多。 |
Save and load is fixed in #872 |
The issue with ‘Failed to save graph file’ has indeed been fixed, but the problem of runtime duration has not been resolved, which is 1.95s. |
Have you tried other device other than A30? We have no A30 at hand. https://github.com/siliconflow/onediff/wiki/Compatibility-with-Nvidia-GPUs |
Time this code on the A100:
with onediff: 1.2s |
https://github.com/search?q=repo%3Asiliconflow%2Fonediff%20set_model_patch_replace&type=code @ccssu Is set_model_patch_replace cost a lot as expected? |
Hi all. I am running into issues with IPAdapter as well with ComfyUI. I am using the latest onediff v1.1.0. During Ksampler execution it spits out an error on every step: Then once it tries to save the graph we get another error and Comfy crashes. `Building a graph for <class 'register_comfy.deep_cache_unet.FastDeepCacheUNet'> ... Aborted (Signal sent by tkill() 1576 1000) Additionally, IPAdapter FaceID hangs indefinitely while trying to load Insightface with CUDA, but continues on CPU. EDIT: The hang appears to be unrelated to OneDiff. |
Are you using the main branch of onediff? And there is a new update on ipadaptor is on the way: #879 |
Can confirm the graph is now being saved and working properly, however the "No module named x" errors still appear in the terminal. |
I have the same issue |
@BradVidler @zhangyongyu Please paste the full error stack here to help debug |
OneDiff git commit id
dev_ipa+isntantid
ef68269
OneFlow version info
Run
python -m oneflow --doctor
and paste it here.version: 0.9.1.dev20240220+cu118
git_commit: 6621521
The complete error message
20240510 20:10:37.106271 111212 cuda_stream.cpp:49] Runtime version 8.7 of cuDNN incompatible with compiletime version 8.9.
Failed to save graph file: ...ComfyUI/input/graphs/anyloraCheckpoint_bakedvaeBlessedFp16.safetensors_BaseModel/bs=1_UNetModel_fbe34f3e3f_3_f1f8a7f1ca61b188044db654a526065b05d40d2524e0d31165e22847fc11c900_0.9.1.dev20240220+cu118.graph! Can't pickle <class 'onediff.infer_compiler.transform.builtin_transform.<class 'register_comfy.CrossAttentionPatch.CrossAttentionPatch'>'>: attribute lookup <class 'register_comfy.CrossAttentionPatch.CrossAttentionPatch'> on onediff.infer_compiler.transform.builtin_transform failed
The text was updated successfully, but these errors were encountered: