-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot update ipadapter weight after compiling the graph in ComfyUI #892
Comments
Debug found that the inability to update is due to an issue with the torch workflow: The workflow weight did not change to a list, but rather to a float, as follows: # ComfyUI/custom_nodes/ComfyUI_IPAdapter_plus/CrossAttentionPatch.py:161
else:
out_ip = optimized_attention(q, ip_k, ip_v, extra_options["n_heads"])
import pdb; pdb.set_trace()
out_ip = out_ip * weight # I'm doing this to get the same results as before
|
The link for the workflow is in the private repo, would you mind to share a public link? Thanks! |
I've tested that changing weights is working, thanks for the help! closing this issue |
Describe the bug
The workflow contains animatediff node and ipadapter node. After compiling the graph, changing the ipadapter weight will not work (the video is still generated with the weight when the graph first get compiled)
Your environment
Ubuntu 20.04
OneDiff git commit id
2249010
OneFlow version info
libibverbs not available, ibv_fork_init skipped
path: ['/home/ubuntu/miniconda3/envs/comfy/lib/python3.10/site-packages/oneflow']
version: 0.9.1.dev20240420+cu121
git_commit: 665bcf8
cmake_build_type: Release
rdma: True
mlir: True
enterprise: False
How To Reproduce
weight_ipadapter.json
After running the workflow, changing the weight in the node "Batch Value Schedule". It's expected to generate video according to the new weights but instead the video is never updated. One extreme case is set a weight to 100 after compiling, we should observe very unreasonable result.
The complete error message
No error message noted.
Additional context
Dependency version is followed this pr: #879
ComfyUI-AnimateDiff-Evolved commit id: f9e0343f4c4606ee6365a9af4a7e16118f1c45e1
The text was updated successfully, but these errors were encountered: