Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use while loops rather than if statements, and colour output #2

Open
lucablackwell opened this issue Dec 2, 2021 · 1 comment
Open

Comments

@lucablackwell
Copy link

Hello all,
I found this repo earlier this morning, and have converted it to PHP on my local machine, as I'm more comfortable with it (though my roots are in python.) I love the idea behind it and it's nice to see other Mr. Robot fans with similar mindsets.
I would like to suggest using while loops to wait for the correct input from the user, as at the moment the functions 'progress' without telling the user, and doesn't stop progress.
image
As seen above, even if the user 'fails' to do the correct steps previously, they can still get on the boat and 'win'.

I'm more than willing to implement these changes, I can fork or commit directly (I may fork to upload my PHP version because why not), just let me know.

@lucablackwell
Copy link
Author

Ah, I forgot to talk about colours - this is optional but I thought it'd be nice to add some colour to the output, like colouring the prompt or ascii art.
image
Again, just a thought, but I'd be happy to put in the work to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant