Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Admin Api to the Admin UI #478

Open
skoruba opened this issue Jan 30, 2020 · 13 comments
Open

Connect Admin Api to the Admin UI #478

skoruba opened this issue Jan 30, 2020 · 13 comments
Assignees

Comments

@skoruba
Copy link
Owner

skoruba commented Jan 30, 2020

Currently, the Admin UI is connected to services directly from the controllers.

I am considering using Admin Api from Admin UI.

It will required some rewrite, but it should be cleaner solution.

Feedback is welcome. 👍

Thanks

@danielmeza
Copy link
Contributor

That's great! This allow us to reduce the maintenance effort and will propagate new features across all system. Remember to use HttpClientFactory and Polly for reduce HTTP connection issues.

@skoruba
Copy link
Owner Author

skoruba commented Jan 30, 2020

Can you describe your idea with Polly?

@skoruba skoruba pinned this issue Feb 3, 2020
@b0
Copy link
Contributor

b0 commented Feb 5, 2020

@skoruba count on me when time comes for this rewrite...

Thank you

@devployment
Copy link

Would that mean in general, staying with MVC or going down the SPA route? If SPA would be an option, any thoughts on the frontend stack? Maybe it would be nice to bring some love to https://aurelia.io/

IMHO they deserve being used by great projects to showcase their stuff. :)

I have not too much experience with Aurelia, but would love to get my hands dirty if the time comes.

@skoruba
Copy link
Owner Author

skoruba commented Feb 12, 2020

I want to work still with MVC. Thanks

@danielmeza
Copy link
Contributor

@devployment I have a lot of experience with aurelia, and it is a awesome JS framework, but it is JS. Although since the project is oriented to rest noting stop us to build a different UI stack. Personally I will chose something closed to the .net world like Blazor, but for now MVC is just fine.

@skoruba
Copy link
Owner Author

skoruba commented Feb 12, 2020

I agree with you @danielmeza - thanks for feedback. Maybe I will consider some rewrite but in the future, current solution with MVC is stable. 👍🏼

@mehyaa
Copy link

mehyaa commented Apr 1, 2020

In my opinion Admin and Admin Api projects can be merged.

Connecting Admin to Api will cause unnecessary navigation, auth steps. That will cause unnecessary delay and complexity. Merging two projects into one and execute all the business logic in common services will be more simple.

Api endpoints can serve under a logical route base name like "/Api/*".

@skoruba
Copy link
Owner Author

skoruba commented Apr 1, 2020

@mehyaa I agree with you. This merge will required bigger rewrite, so I will work on this issue in Q3 of this year - help with this is really welcome. 👍

@vicentt
Copy link

vicentt commented Jul 27, 2020

Hey @skoruba!
Do you want to merge the projects or use the Api on AdminUI for the moment?

@raminassar
Copy link

any progress on this?

@skoruba
Copy link
Owner Author

skoruba commented Dec 29, 2021

Unfortunately not, currently postponed, I am working on new features to Duende IdentityServer Admin UI.

@jdmallen
Copy link

jdmallen commented Nov 7, 2022

Can you describe your idea with Polly?

@skoruba Not @danielmeza, but I know what he's talking about and fully agree. Since no one addressed your question: Polly is a 3rd party transient fault handling framework for .NET that is fully endorsed by Micsosoft, so much as that they introduced their own extension packages for Polly as part of .NET, including some to add retries and other forms of transient fault handling to the HttpClientFactory pattern.

The HttpClientFactory pattern along with Polly is the new and preferred way of injecting HttpClients into classes (over the old way of making it static, or worse, constructed with every instance). More here on using it with Polly.

Nick Chapsas (@Elfocrash) made a great and quick video recently on implementing it in a new .NET project if you want to dive in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants