Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Settings in ReactHint Props #2

Closed
jcuenod opened this issue May 10, 2017 · 7 comments
Closed

Global Settings in ReactHint Props #2

jcuenod opened this issue May 10, 2017 · 7 comments

Comments

@jcuenod
Copy link

jcuenod commented May 10, 2017

It would be great if we could provide global settings/defaults to ReactHint through the component, for example:

<ReactHint displayDelay=100 hideDelay=300 transition="slide" />

Also, supporting those settings would be great as well ;)

@slmgc
Copy link
Owner

slmgc commented May 12, 2017

@jcuenod yep. I plan to add these settings in the future update. Btw, do you think it makes sense to add both show/hide delay settings?

@slmgc
Copy link
Owner

slmgc commented Aug 21, 2017

Released v2, added delay-related global settings

@slmgc slmgc closed this as completed Aug 21, 2017
@jcuenod
Copy link
Author

jcuenod commented Aug 21, 2017

@slmgc Great! Sorry - don't know how I missed your question on the previous message.
The reason I had thought hide delay would be handy is because it gives the user a chance to hover on the hint if it's a harder target.

@slmgc
Copy link
Owner

slmgc commented Aug 22, 2017

@jcuenod at this point a unified delay setting for both hide/show was implemented. This can be easily extended later if there will be a need for it.

@jcuenod
Copy link
Author

jcuenod commented Aug 22, 2017

@slmgc oh ja! thanks for taking the suggestion of the global setting.

@slmgc
Copy link
Owner

slmgc commented Aug 21, 2019

I am working on the next API, it's halfway there, but I would like to get as much feedback as possible about all the inconveniences with the current API and have a proper discussion around the new API. If you could join the discussion it would be awesome: #46

@jcuenod
Copy link
Author

jcuenod commented Aug 21, 2019

Thanks for the invitation but I haven't been using react-hint for a while now so I'm probably not the ideal person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants