Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database: fix typo in Comcast domain #102

Open
ghost opened this issue May 6, 2015 · 0 comments
Open

Database: fix typo in Comcast domain #102

ghost opened this issue May 6, 2015 · 0 comments

Comments

@ghost
Copy link

ghost commented May 6, 2015

When I installed the parser via PHP Composer, in my referers.json I saw this typo in domain:

"Comcast": {
            "domains": [
                "serach.comcast.net"
            ], 
            "parameters": [
                "q"
            ]
        }, 

And then I looked at the referers.yml file in the repo and saw a duplicate of Comcast:

https://github.com/snowplow/referer-parser/blob/master/resources/referers.yml#L774

I'm not sure how the lists are compiled or what the source is but I'm sure with this information you'll be able to fix it everywhere it occurs :)

@alexanderdean alexanderdean added this to the Release July 2017 milestone Jun 12, 2017
@alexanderdean alexanderdean changed the title Comcast domain typo in referers.yml Database: fix typo in Comcast domain Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant