Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[dev]: 🤔 add adria-label to sd-icon when built-in #1170

Open
12 tasks
karlbaumhauer opened this issue Jun 25, 2024 · 0 comments
Open
12 tasks

fix[dev]: 🤔 add adria-label to sd-icon when built-in #1170

karlbaumhauer opened this issue Jun 25, 2024 · 0 comments
Labels
🔧 code needs changes in code Subtask Epic subtasks

Comments

@karlbaumhauer
Copy link
Contributor

karlbaumhauer commented Jun 25, 2024

Description

This tasks describes the Figma implementation for: solid-design-system/internal#78
Chapter 9.1.1.1a in the file "Test Details"

Task

All built-in sd-icons need an aria-label or the otion to set it from outside. This needs to be added to the following components:

  • checkmark for positive validation in sd-radio-group
  • +/- buttons inside the sd-input (sample: currency stepper)
  • sd-tooltip when used with sd-input

Open Questions towards design

  • Question1
  • Question2

DoR

  • Item has been estimated by the team
  • Item dependencies have been identified and documented

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@karlbaumhauer karlbaumhauer added Subtask Epic subtasks 🔧 code needs changes in code labels Jun 25, 2024
@karlbaumhauer karlbaumhauer changed the title fix[dev]: 🤔 add adria-label to sd-icon in sd-radio-group fix[dev]: 🤔 add adria-label to sd-icon when built-in Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 code needs changes in code Subtask Epic subtasks
Projects
Status: 🛠️ To be pre-refined
Development

No branches or pull requests

1 participant