Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat [design]: ✨ add icon slot to sd-accordion #1195

Closed
4 of 11 tasks
mariohamann opened this issue Jul 8, 2024 · 3 comments
Closed
4 of 11 tasks

feat [design]: ✨ add icon slot to sd-accordion #1195

mariohamann opened this issue Jul 8, 2024 · 3 comments
Assignees
Labels
🙌 Epic 🎨 figma needs changes in Figma

Comments

@mariohamann
Copy link
Contributor

mariohamann commented Jul 8, 2024

User Story

As a user of the Solid Design System, I would like to have a dedicated slot to place icons inside a sd-accordion.

Suggested Solution

CleanShot 2024-07-08 at 11 38 56@2x

Ideally the icon appears here, but of course vertically centered. This could help us especially in #1188

DoR

  • Item has business value
  • Item have been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Brand approval (---> pending)
  • Figma documentation file incl. hand-off has been created/updated (if applicable)
  • Tokens have been applied/updated (if applicable)
  • Crosslinks are created/updated
  • Implementation works successfully on figma branch
  • Published in Figma and communicated in release notes
  • Issues for dependencies have been created (if neccessary)
@mariohamann
Copy link
Contributor Author

mariohamann commented Jul 8, 2024

@MartaPintoTeixeira Would you mind making a little PoC in a separate branch for sd-accordion?

We would need a boolean property which enables a slot which contains an icon. For comparison, check out how we've done it in sd-button.

@yoezlem
Copy link
Contributor

yoezlem commented Jul 24, 2024

@mariohamann @karlbaumhauer We only needed this feature to find a smooth solution for sd-quickfact, right? Since we now have a solution for that, do we still need this feature in sd-accordion? Otherwise, I would like to close the ticket.

@mariohamann
Copy link
Contributor Author

@coraliefeil Maybe you can have a look but we close it for the moment. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙌 Epic 🎨 figma needs changes in Figma
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants