Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 Incorrect exportparts in autocomplete-config #1196

Open
9 tasks
kirchsuSICKAG opened this issue Jul 8, 2024 · 0 comments
Open
9 tasks

fix: 🤔 Incorrect exportparts in autocomplete-config #1196

kirchsuSICKAG opened this issue Jul 8, 2024 · 0 comments

Comments

@kirchsuSICKAG
Copy link

Current behavior

The autocomplete-config.ts file is currently providing two parts, which can be used for styling: the listbox part and the popup__content.
Currently only the listbox part is working.

Expected behavior

Both parts listbox and popup__content are working.

Steps to reproduce

Technical Information

The popup__content is exported via:

    popup?.setAttribute('exportparts', 'popup__content');
Bildschirmfoto 2024-07-08 um 15 15 14

but the popup component does not have a part called 'popup__content' but only 'popup'

So the fix would be to either do one of the following:

popup?.setAttribute('exportparts', 'popup:popup__content');
popup?.setAttribute('exportparts', 'popup');

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🛠️ To be pre-refined
Development

No branches or pull requests

1 participant