Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making mod_pettifor the default elemental scale #142

Open
sgbaird opened this issue Jun 29, 2022 · 2 comments
Open

Consider making mod_pettifor the default elemental scale #142

sgbaird opened this issue Jun 29, 2022 · 2 comments

Comments

@sgbaird
Copy link
Member

sgbaird commented Jun 29, 2022

@kjappelbaum thoughts?
@kjappelbaum
Copy link
Contributor

Sounds good to me!

@sgbaird
Copy link
Member Author

sgbaird commented Jul 8, 2022

I think I'll still wait until I run and get the results back for hyperparameter optimization, though I won't be surprised if it settles on mod_pettifor instead of atomic. If I run into issues with the hyperopt, then I'll probably still swing back and change the default (which will probably necessitate rewriting some of the unit tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjappelbaum @sgbaird