Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we set the lower bound of the xtal2png ranges as 0 or as the minimum across all MP compounds? #42

Open
sgbaird opened this issue May 31, 2022 · 0 comments
Labels
hyperparameter Hyperparameters to consider optimizing

Comments

@sgbaird
Copy link
Member

sgbaird commented May 31, 2022

Implementing for now as minimum across all MP compounds, but this is another hyperparameter choice (technically, the hyperparameter might be a scaling factor between 0 and 1 of the minimum). This would be an alternative to leaving each of the parameter ranges as tunable parameters themselves, and might be a reasonable reduction to the search space (i.e. only leave the upper bound limits as individual tunable parameters).

@sgbaird sgbaird added the hyperparameter Hyperparameters to consider optimizing label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hyperparameter Hyperparameters to consider optimizing
Projects
None yet
Development

No branches or pull requests

1 participant