-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make type definitions available through TSD installation #35
Comments
@tedvanderveen thanks, I'll look into it, though I'm not sure how TSD accepts contributed code as there doesn't seem to be any pull requests with new definitions there. It the meantime the |
@xiphiaz please refer to http://definitelytyped.org/guides/contributing.html |
@xiphiaz Just like in your own code, we use a central "typings" folder that holds all external type definitions and this folder is maintained using TSD. So using bower and reference the .d.ts file from outside the typings folder would break our setup. |
@tedvanderveen I am intending to add angular-jwt-auth to TSD when I find some time, but in the meantime you can actually have bower referenced The local typings file can automatically generate the linkings to dependencies with the Note that I had to do a bit of a hack to stop dependency collisions however - you can see it in https://github.com/spira/spira/blob/master/gulpfile.js#L115 Basically what the spira gulpfile does is copy all the As I mentioned, I do intend to add this package to definitely typed, but I don't currently have the time - I'll have to restructure the distributed file slightly, and add tests. |
@xiphiaz cool, thanks for this. Please give me shout when you found time to submit to TSD or if I can support you with anything. |
@xiphiaz did you have a chance to look into this? Thanks |
@tedvanderveen I'm finally able to give this library some love - see #44 - I am refactoring to use commonjs pattern for standard loading with typescript, and be typings compatible. |
@xiphiaz Nice! |
Closed in #50 |
Really like this library and we would like to replace angular-jwt with this one.
The only thing that seems to be missing is a reference to the type definitions file through definitelytyped and thereby the ability to streamline the installation using TSD commands.
Please add these to https://github.com/borisyankov/DefinitelyTyped
http://definitelytyped.org/tsd/
The text was updated successfully, but these errors were encountered: