Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Option?) to stop application on compile errors #55

Open
axos88 opened this issue Oct 12, 2015 · 4 comments
Open

(Option?) to stop application on compile errors #55

axos88 opened this issue Oct 12, 2015 · 4 comments
Labels

Comments

@axos88
Copy link

axos88 commented Oct 12, 2015

Hello,

I would like to be able to configure revolver in a way that it would stop the application on compile errors.

Eg:

sbt ~re-start
// application runs, start implementing new feature
// make changes to the code, but accidentally break compilation
// recompilation triggered, and it fails

At this point I would expect the application running in the background to stop running. I am developing a webapp, so I expect navigating to the correct address to give an unable to connect error.

What happens is that the former version keeps on running, and unless I take a good look at the compilation output, I am interacting with the old version, and wondering why my changes are not taking any effect

@axos88
Copy link
Author

axos88 commented Nov 27, 2015

@jrudolph

@jrudolph
Copy link
Member

I agree that this would be nice to have.

@matanox
Copy link

matanox commented Mar 23, 2016

Just looking around, I think this should only be optional or at least governed by a flag. In my flows, restarting the server when code is broken can be misleading and (very) unproductive. I don't think we should have a single semantics fits all philosophy here.

@axos88
Copy link
Author

axos88 commented May 3, 2019

Just searched for this again, and stumbled upon my own issue report here :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants