-
Notifications
You must be signed in to change notification settings - Fork 38k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ReactorClientHttpConnector
lifecycle-aware
#31180
Comments
ReactorClientHttpConnector
lifecycle-aware
@sdeleuze Does it make module spring-web dependency on spring-context mandatory instead of not optional? My project uses ReactorClientHttpConnector explicitly and before spring 6.2 spring-context wasn't required, but now it is (java.lang.NoClassDefFoundError: org/springframework/context/SmartLifecycle) |
This change makes this class depend on spring-context, but spring-web has been optionally depending on spring-context for years. As of Spring Framework 6.1, you'll need spring-context on the classpath to use this class. |
I have updated the upgrade notes accordingly. |
I have a similar problem like @agorbachenko. We were using only the I also had a look into this a bit and I don't quite understand how this works for the intended purposes? Let's say I want to use the
Will CRaC work in this example? From what I could see in the smoke tests WebClientConfiguration in the smoke tests the auto configured Does it make more sense to have a |
Yes, and that's a good point, I have refined the smoke test to not customize the That's IMO one more reason to keep things as they are implemented, and just add the additional |
Thanks for the pointer @sdeleuze. I missed that class, seems like IntelliJ isn't finding that usage if I use the auto configure as a dependency only. We went with adding the |
In order to improve the compatibility with JVM Checkpoint Restore (aka CRaC),
ReactorClientHttpConnector
should implement theLifecycle
interface.The text was updated successfully, but these errors were encountered: