Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$this inside closure #14

Open
ssnepenthe opened this issue May 17, 2018 · 0 comments
Open

$this inside closure #14

ssnepenthe opened this issue May 17, 2018 · 0 comments

Comments

@ssnepenthe
Copy link
Owner

ssnepenthe commented May 17, 2018

array_map( function( array $vulnerability ) {
return new Vulnerability( $this->package, $vulnerability );
}, $data['vulnerabilities'] )

Is it even worth pretending to support PHP 5.3 at this point?

WP_Mock@dev-dev is required as a dev dependency - As of the latest commit to soter-core this put us at ~0.2.x which required PHP5.6+. Currently, it would pull ~0.3.x which requires PHP7+.

All that to say that it is unlikely this package will ever be properly tested below PHP5.6 going forward, and maybe not even below 7.0.

Alternatively - consider introducing a tool such as https://github.com/wimg/PHPCompatibility to avoid simple issues such as this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant