Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HardwareSerial Error Callback #1162

Closed
0x6d61726b opened this issue Sep 1, 2020 · 3 comments
Closed

HardwareSerial Error Callback #1162

0x6d61726b opened this issue Sep 1, 2020 · 3 comments
Labels
enhancement New feature or request help wanted 🙏 Extra attention is needed

Comments

@0x6d61726b
Copy link

For implementing a custom protocol handler based on UART, it is necessary to get knowledge about the LIN Break Detection, Framing Error and Parity Error signals. What is the proposed way for such an implementation?

Would it be ok to propose an extenions of the HarewareSerial class to provide a error callback mechanism that gets called by the HAL_UART_ErrorCallback()? If so, I would be happy to make such a proposal for further discussion.

@fpistm
Copy link
Member

fpistm commented Sep 1, 2020

Hi @0x6d61726b
HardwareSerial follows the Arduino API that's why there is no error CB.
Anyway feel free to contribute and propose a PR, any contribution are welcome.
But pay attention to not break the standard API 😉

@0x6d61726b
Copy link
Author

Hi @fpistm, thanks for the positive feedback. 😊
I was unsure if an extension is possible.
Not altering the standard API functionality is taken for granted.

I will come back in the next days with the proposal.

@fpistm fpistm added help wanted 🙏 Extra attention is needed New feature labels Sep 10, 2020
@fpistm fpistm mentioned this issue Jun 11, 2021
4 tasks
@fpistm
Copy link
Member

fpistm commented Jun 11, 2021

Added to [U(S)ART] request list #1418

@fpistm fpistm closed this as completed Jun 11, 2021
@fpistm fpistm added enhancement New feature or request and removed Request labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted 🙏 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants