fix: fix type error

storipress · Apr 2, 2024 · 31e8586 · 31e8586
1 parent 8b1c9a2
commit 31e8586
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/packages/karbon/src/cli/plugins/importer-checker.ts b/packages/karbon/src/cli/plugins/importer-checker.ts
@@ -1,12 +1,17 @@
 import consola from 'consola'
+import type { Plugin } from 'vite'
 
-export default function importerChecker() {
+export default function importerChecker(): Plugin {
   const virtualModuleId = '#imports'
   const CHECK_IMPORTER_DIR = ['article-layout', 'editor-blocks']
 
   return {
     name: 'importer-checker',
     resolveId(id, importer) {
+      if (!importer) {
+        return
+      }
+
       const findImporter = CHECK_IMPORTER_DIR.find((dir) => importer.includes(dir))
 
       if (importer && findImporter) {

diff --git a/packages/karbon/src/module.ts b/packages/karbon/src/module.ts
@@ -26,7 +26,7 @@ import type { HookResult, NuxtPlugin } from '@nuxt/schema'
 import { resolveSEOProviders } from './seo-provider'
 import { versionSafe } from './cli/checkFile'
 import type {
-  ArticleMeta,
+  BaseMeta,
   DeskMeta,
   ModuleOptions,
   ModulePublicRuntimeConfig,
@@ -81,7 +81,7 @@ const resources: ModuleOptions['resources'] = {
     enable: true,
     getIdentity: ({ id }) => ({ type: 'article', id }),
     isValid: stubTrue,
-    toURL: ({ id }: ArticleMeta) => `/posts/${id}`,
+    toURL: ({ id }: BaseMeta) => `/posts/${id}`,
   },
   desk: {
     route: '/desks/:id',

diff --git a/packages/karbon/src/modules/instantsearch/index.ts b/packages/karbon/src/modules/instantsearch/index.ts
@@ -4,6 +4,7 @@ export default defineNuxtModule({
   async setup() {
     const widgetSource = await resolvePath('vue-instantsearch/vue3/es/src/widgets')
     const promises = []
+    // @ts-expect-error internal pkg
     const widgets = await import('vue-instantsearch/vue3/es/src/widgets.js')
     for (const name of Object.keys(widgets)) {
       promises.push(

diff --git a/packages/karbon/src/runtime/types.ts b/packages/karbon/src/runtime/types.ts
@@ -118,6 +118,7 @@ export interface IdComparisonMap {
 }
 
 export interface URLGenerators {
+  // @ts-expect-error no idea only this will have error
   article: ResourcePage<ArticleMeta>
   desk: ResourcePage<DeskMeta>
   author: ResourcePage<AuthorMeta>