You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good point. Actually, the generate() method is supposed to be used only by the flow class so it might be also _generate() And looking at it the return type is too general.
Also, the flow class should be already taking care of passing the right inputs so I don't know why I added the filtered_inputs check.
Why not use **kwargs here?
llmflows/llmflows/flows/functional_flowstep.py
Line 42 in 3c4ceb7
Then you can name keyword args to the function (i.e.,
generate
), and the remaining will be the arguments forflowstep_fn
, so this will go awayllmflows/llmflows/flows/functional_flowstep.py
Lines 58 to 60 in 3c4ceb7
Rename
flowstep_fn
toinner_fn
orstep_fn
; it's part of aflowstep
class, so the context is already clear.llmflows/llmflows/flows/functional_flowstep.py
Line 39 in 3c4ceb7
^ is not used.
The text was updated successfully, but these errors were encountered: