New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: use type hints for input arguments #9

Open

inspiralpatterns opened this issue Jul 12, 2023 · 1 comment

Labels

good first issue

Collaborator

inspiralpatterns commented Jul 12, 2023

llmflows/llmflows/llms/openai.py

Line 55 in 6ce79a8

def prepare_results(self, model_outputs, retries) -> tuple[str, dict, dict]:

It would be much appreciated if you used type hints for the input arguments in your methods - with this suggestion extended to the whole code base.

Owner

stoyan-stoyanov commented Jul 13, 2023

makes sense

stoyan-stoyanov self-assigned this

stoyan-stoyanov added the good first issue label

stoyan-stoyanov removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment