Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Field Payment Method Label #2633

Open
patric-boehner opened this issue Oct 17, 2023 · 3 comments
Open

Checkout Field Payment Method Label #2633

patric-boehner opened this issue Oct 17, 2023 · 3 comments
Labels
Difficulty: Medium Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help. has PR

Comments

@patric-boehner
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The payment method radio form fields don't have a label. It has a radio input and a link element that visually acts as the label.

Describe the solution you'd like
This should potentially be changed to a label like other radio fields.

Describe alternatives you've considered
if not possible the input could have an aria-labelledby pointing to the link element.
https://dequeuniversity.com/rules/axe/4.7/label

Additional context
Hopefully, this is the right place to report or discuss this.

@andrewlimaza andrewlimaza added Difficulty: Medium Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help. labels Jan 9, 2024
@andrewlimaza
Copy link
Contributor

@MaximilianoRicoTabo
Copy link
Contributor

@patric-boehner
Copy link
Contributor Author

@MaximilianoRicoTabo @andrewlimaza That change looks great. The only thing I can see is the "pmpro_radio" class has been removed from the label. That could be part of a larger change, but it might break some people's styling. Or, to bring it in line with the other classes, maybe it should be updated to "pmpro_radio_lable".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Medium Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help. has PR
Projects
None yet
Development

No branches or pull requests

5 participants