Do not raise exceptions if a field is overwritten

[movabo]

Hello,

I came across this comment in the code:

# TODO: Raise exception if field_name already in fields

This is in the method which resolves the field types and the comment is about checking if a field with the same name already exists.
I opened this discussion to argue against the addition of such exception.

Adding the exception would mean, that it would be impossible to override fields from inherited classes.
E.g. the following example would not work:

from typing import List
import strawberry


@strawberry.input
class ImageInput:
    link: str
    description: str


@strawberry.type
class Image(ImageInput):
    pass


@strawberry.input
class NoteInput:
    headline: str
    text: str

    image: List[ImageInput]


@strawberry.type
class Note(NoteInput):
    image: List[Image]

This example demonstrates a use case where a user can read and add notes with as few code duplication as possible.
To have the correct types for image, we must override it depending on the type of the class (i.e. type or input).

Thus I would recommend not adding such exception or allow disabling it. (Another option might be a disallowable option.)

I hope I didn't oversee anything why above example is a bad idea.