Potential Tick Duplication In extract_pool_events_and_positions module

[steegecs]

In viewing the extract_pool_events_and_positions function in the filtering.rs file used by the extract_pool_events_and_positions module, it looks like you might end up creating the same tick more than once. This is because of the or logic for creating both ticks. From my understanding, it is possible that only one of the ticks already exists, so you should run separate conditions for each tick to trigger the new tick creation.

The scenario I am thinking of is there is a new pool, and the first two deposits are as follows:

• User 1 deposits $100 on tick 10 to 15
• User 2 deposits $100 on tick 10 to 20

When the user makes two deposits, tick 10 already exists, but tick 20 does not. So you would only acknowledge that a new tick was created for tick 20.

[steegecs]

Maybe something like this?

[maoueh]

@abourget @Eduard-Voiculescu

[Eduard-Voiculescu]

Hey @steegecs, so we actually removed the create_upper_tick and create_lower_tick because we had some issues on detecting when a tick was actually created.

We found that the contract emits a initialize storage change on the contract for a given pool: https://github.com/Uniswap/v3-core/blob/main/contracts/libraries/Tick.sol#L36

But interestingly, a pool has their ticks which will move a little bit depending on the added and removed liquidity in it. So this makes it that we would sometimes miss some ticks as their had already been initialized.

So the if create_lower_tick or create_upper_tick would be false, we would miss some ticks. Hence why whenever we get a mint we just check the prices_from_tick_index.

[abourget]

Was this resolved? Can we close this?

[Eduard-Voiculescu]

@steegecs Do you need any more clarification?