New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position liquidities #18

Open

Eduard-Voiculescu opened this issue Jun 29, 2023 · 0 comments

Collaborator

Eduard-Voiculescu commented Jun 29, 2023

Currently the liquidities for the positions are wrong.

We have 2 issues:

When someone decides to increase liquidity on a pool, they can do that one of two ways:

mint event (this will create and emit a new token id for the position)
increase liquidity (direct call to the NFT contract and the token id is provided by the user)
This means that we have to aggregate the liquidities so we need an intermediate store for the values

Decrease liquidity does not decrease the liquidity of the pool - we need to add a negative value for the amount of the liquidity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment