Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Spellcheck only comments" hangs the extension #368

Closed
seba-eng opened this issue Jul 29, 2019 · 3 comments
Closed

"Spellcheck only comments" hangs the extension #368

seba-eng opened this issue Jul 29, 2019 · 3 comments

Comments

@seba-eng
Copy link

Using the regex from #107 in settings.json to check only comments in python hangs the extension for me in a 300 lines file with many docstrings.

@seba-eng
Copy link
Author

seba-eng commented Aug 1, 2019

I don't know if that's the source for the hanging, but discovered one problem:
""" errror """ is detected as unknown word. But this:

""" errror
"""

is a valid commend in python but not detected.

relevant part of settings.json looks like this:

"cSpell.languageSettings": [
        {
            "languageId": "python",
            "includeRegExpList": [
                "/#.*/",
                "/\"\"\"(.*?\\n?)+?\"\"\"/g",
                "/'''(.*?\\n?)+?'''/g",
                "string"
            ]
        }
    ],

Edit: I'm using windows with CRLF line endings, could that be a problem?

@Jason3S
Copy link
Collaborator

Jason3S commented Feb 18, 2020

@seba-eng the original RegExp from #107 is incorrect and will cause the extension to hang. Please see discussion in #431.
I have updated #107 with the correct RegExp.

@Jason3S Jason3S closed this as completed Feb 18, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants