Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote PDF endpoint does not work #1303

Closed
jhhayashi opened this issue Apr 16, 2024 · 4 comments · Fixed by #1306
Closed

Quote PDF endpoint does not work #1303

jhhayashi opened this issue Apr 16, 2024 · 4 comments · Fixed by #1306
Assignees
Labels

Comments

@jhhayashi
Copy link

jhhayashi commented Apr 16, 2024

Describe the bug

Looks like the download quote PDF endpoint is under a different domain than the other API endpoints, but the client does not update the domain in the request

To Reproduce

resource = stripe.Quote.retrieve(<quote_id>)
resource.pdf()

causes

InvalidRequestError: Unrecognized request URL (GET: /v1/quotes/<quote_id>/pdf). Please see https://stripe.com/docs or we can help at https://support.stripe.com/.

Expected behavior

The client should successfully request the quote endpoint

Code snippets

No response

OS

macOS

Language version

Python 3.12.3

Library version

v9.1.0

API version

2024-04-10

Additional context

No response

@jhhayashi jhhayashi added the bug label Apr 16, 2024
@remi-stripe remi-stripe self-assigned this Apr 16, 2024
@remi-stripe
Copy link
Contributor

Hey @jhhayashi thanks a lot for the report and really sorry for the trouble here. Looks like we have a bug in our code here where we don't properly pass the base_address like we should. Seem like it broke a few months ago in a refactor on this change

We'll work on a fix quickly and follow up.

@ramya-stripe
Copy link
Contributor

Thanks for reporting this @jhhayashi
The fix will be out in tomorrow's release of the stripe-python library

@jhhayashi
Copy link
Author

Awesome, thanks for the quick turnaround!

@ramya-stripe
Copy link
Contributor

The fix is out in version 9.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants