Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong game getting loaded #11

Open
btr70 opened this issue Jan 11, 2023 · 1 comment
Open

Wrong game getting loaded #11

btr70 opened this issue Jan 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@btr70
Copy link

btr70 commented Jan 11, 2023

Sometimes the wrong game gets loaded when typing in the game ID.
Games are retrieved form J-Archive with each keystroke, and sometimes it's possible that the last keystroke is missed. The result is that the correct ID shows in the input field, but the description below it is for a different game.

Typing slowly or pasting from the clipboard gets around it, but it happens easily enough that it might be worth putting a short delay before fetching the game.

@stuartthomas25
Copy link
Owner

Oh bummer, sorry about this. I never really type in a game number so I never noticed this.

Each time the textbox changes it spawns a thread which updates the game. It's possible that the order of these threads changes, i.e. one thread might take a little longer. I'm not quite sure how to fix this. Maybe a delay to check if the number is still the same as when it was first typed in?

@stuartthomas25 stuartthomas25 added the bug Something isn't working label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants