-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I may have a fix for "support for webpack v5" #1740
Comments
@sapegin or @elevatebart why is #1703 locked? Can we re-open it? We need a space for webpack 5 issues to be raised |
This comment has been minimized.
This comment has been minimized.
@jasonwilliams @rgbkrk unfortunately react-styleguidist is relying on a library that is part of create-react-app react-dev-utils. This library is not compatible with webpack 5 yet. There is good news though: It will be getting updated soon as this PR has just been merged 11 days ago. When the lib is released I will update the dependency and release a version of rsg@11. Until then we can only hack a fix. I have been (loosely) trying to do so but without success yet. |
I was able to use the react-dev-utils pre-release in a fork for react-styleguidist. I don't know if people want to wait or perhaps react-styleguidist can also have a pre-release. I do have to fix a few things in my project using react-styleguidist but I don't think that's related to either styleguidist or react-dev-utils https://github.com/juanca/react-styleguidist/tree/master P.S. I would have made a PR but I don't seem to have a compatible version of NPM and I had to commit the artifacts. |
🎉 This issue has been resolved in version 11.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I am opening this issue because the original one was flagged as spam and I coudn't comment on it
#1703
I was able to solve this problem as described:
1 - Eject your project;
2 - Fix webpack configuration to port to webpack v5; how to do it?
3 - Search for
formatWebpackMessages(webpackMessages)
insideconfig/build.js
;4 - Replace with the following block of code:
I hope this helps.
EDIT:
Since we have to support webpack v4 and v5, I made the above code detect if the error object is from webpack 4
The text was updated successfully, but these errors were encountered: