Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode CrsqlSeq, CrsqlDbVersion and Version as varints #188

Open
jeromegn opened this issue Apr 12, 2024 · 1 comment
Open

Encode CrsqlSeq, CrsqlDbVersion and Version as varints #188

jeromegn opened this issue Apr 12, 2024 · 1 comment

Comments

@jeromegn
Copy link
Member

Doing so both in transit and in memory should bring in significant benefits. For example: using a u64 for CrsqlSeq when they should most-often fit in a u8 is a waste.
@jeromegn
Copy link
Member Author

With #189, this is only going to be relevant for bandwidth concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeromegn