Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor base class to be service-agnostic #18

Open
supremebeing7 opened this issue Jun 17, 2016 · 0 comments
Open

Refactor base class to be service-agnostic #18

supremebeing7 opened this issue Jun 17, 2016 · 0 comments
Labels
refactoring

Comments

@supremebeing7
Copy link
Owner

Eventually, the gem should ask the user which services to integrate. For now, the base class TimeLogRobot makes calls to Toggl::Report and JIRA::WorkLogger, which is not great. The calls instead should be made to non-namespaced services, which then inspect some param/argument and route to the proper service accordingly. See the Entry and Tagger models for examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@supremebeing7