Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Font Awesome from 4 to 6 #1656

Closed
ikedas opened this issue Apr 8, 2023 · 6 comments · Fixed by #1657
Closed

Switch Font Awesome from 4 to 6 #1656

ikedas opened this issue Apr 8, 2023 · 6 comments · Fixed by #1657
Assignees
Labels
enhancement ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@ikedas
Copy link
Member

ikedas commented Apr 8, 2023

Expected Behavior

Font Awesome should be up-to-date, i.e. 6.4.x.

Current Behavior

Font Awesome bundled in Sympa is outdated, i.e. 4.3.0.

Possible Solution

Upgrade Font Awesome: See also the instruction.

@ikedas ikedas self-assigned this Apr 8, 2023
@racke
Copy link
Contributor

racke commented Apr 9, 2023

I looked up the status of the Debian package, which says:

Please note that this package provides Font Awesome 4 (not Font Awesome 5 or Font Awesome 6 which are different fonts with different licensing).

What is the difference between these releases?

There is also the fork of Font Awesome, which was created because of the licensing situation (if I remember correctly).

@ikedas
Copy link
Member Author

ikedas commented Apr 10, 2023

I looked up the status of the Debian package, which says:

Please note that this package provides Font Awesome 4 (not Font Awesome 5 or Font Awesome 6 which are different fonts with different licensing).

What is the difference between these releases?

Icon names changed after FA4. So we have to modify templates.

Abolut the license, it seems for me that FA4 and FA6 Free differ in some details but basically they keep the free/open source license. Am I right?

There is also the fork of Font Awesome, which was created because of the licensing situation (if I remember correctly).

I just learned about Fork Awesome. I don't see where the ForkA license improves things. At least this can be a drop-in replacement for FA4 which has already reached EOL.

Font Awesome 4.3.0 Fork Awesome 1.2.0 Font Awesome 6.4.0 Free
total size (TTF) 93 888 219 004 655 960
number of font files 1 1 4
number of icons 560 796 2 020
compatible to FA4

-

yes

no

@ikedas
Copy link
Member Author

ikedas commented Apr 12, 2023

These are all icons currently used by Sympa.

There appears to be a slight design change (Especially noticeable in 6, 22, 37, 38, etc.).

Font Awesome 4.3.0 Font Awesome 6.4.0 Free (red: name changed)
image image

@ikedas
Copy link
Member Author

ikedas commented Apr 12, 2023

Please check the PR above. Thanks!

@ikedas
Copy link
Member Author

ikedas commented Apr 12, 2023

PR above was applied to lists.sympa.community.

@ikedas ikedas added this to the 6.2.72 milestone Apr 13, 2023
@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Apr 15, 2023
@ikedas
Copy link
Member Author

ikedas commented Apr 15, 2023

Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants