-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data sources component #20
Comments
I'll take a look where the information is kept and how it can be relayed to the new frontend. |
The data sources information is kept in the configuration only as it seems. I will examined it further and check if there is a way to expose it from the 6.2. UI. |
There are two types of parameters for inclusion: The former allows setting of datasource in detail[1], like presented here. The latter allows restricted setting referring predefined templates[2]. On 6.2, the two above share code and configuration schema, however, settings for the former is stored in list config file while the latter is stored in separate *.incl files without UI access. As an idea, I suggest they would be unified into single framework: separate *.incl files editable by UI. |
I strongly agree with Soji. These two mechanisms are in fine the very same, though they provide different way to create inclusions. Having separate *.incl files have many advantages which all amount to referential integrity:
It also extends the delegation properties: you can easily delegate data source management to other users when using *.incl, as all the see are the parameters of a query without seeing the actual query or database host or password, etc. We should simply improve the current *.incl edition (by giving proper form fields to setup the query parameters) and add an "edit" button that would switch to the actual query parameter edition, such as the the one Sandhose presented. |
Code for data source was renewed on #693. What would be added to realize this FR? |
We want to integrate the new components created for Sympa 7 on the sympa-vue repository in the current version of Sympa.
This is how it might look like in Sympa 7:
(see here for all the screen, including the desktop ones)
This is how it might look like in the current Sympa UI:
(those are quick sketches and are not pixel-perfect)
This might be as simple as tweaking the tt2 templates, and exposing the lists data sources as a JSON array to the client (we may want to have this interface as an opt-in thing if we don't want to break the current UX). I'm not sure of what's involved in doing that, so I'm calling for help to the backend guys 😶
The component is currently in development by @ludovicm67 ; see sympa-community/sympa-vue#1
The text was updated successfully, but these errors were encountered: