Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review.tt2 button correction. #98

Closed
MargoM opened this issue Oct 14, 2017 · 3 comments
Closed

Review.tt2 button correction. #98

MargoM opened this issue Oct 14, 2017 · 3 comments
Labels
Milestone

Comments

@MargoM
Copy link

MargoM commented Oct 14, 2017

Hello!

I think some buttons ("Add" and "Multiple add") in review.tt2 are not in correct position. Screenshot: https://i.imgur.com/dZY2AYR.png
It seems that after this change 49f2825#diff-66948009965069770acd20e212cdbbe6 some html code (breaks and stuff) disappeared.

Sympa: 6.2.20.

Best wishes!

@ikedas
Copy link
Member

ikedas commented Oct 15, 2017

@MargoM, could you give the modification to correct the problem?

Submitting pull request is better way. But if you are not familiar with PR, please post the diff against current template.

@MargoM
Copy link
Author

MargoM commented Oct 15, 2017

@ikedas, a suggested modification:

default/web_tt2/review.tt2, (https://github.com/sympa-community/sympa/blob/master/default/web_tt2/review.tt2)

      <label for="quietly">
        [%|loc%]Quiet (don't send welcome email)[%END%]
      </label>
+     <br />
      <input class="MainMenuLinks" type="submit" name="action_add"
       value="[%|loc%]Add[%END%]" />
    </div>
    </fieldset>
    </form>
    <h4>[%|loc%]To add multiple users:[%END%]</h4>
    <p>[%|loc%]Click the Multiple Add button below to bulk-add users using a form.  (Alternatively, consider using a data-source such as SQL or an Active Directory Group).[%END%]</p>
    <div>
+   <p>
      <a class="button" href="[% 'import' | url_rel([list]) %]">
        [%|loc%]Multiple add[%END%]
      </a>
+   </p>
    </div>
[%~ END %]

Result: https://i.imgur.com/a3KIR1u.png

@ikedas ikedas added the bug label Oct 15, 2017
@ikedas ikedas added this to the 6.2.24 milestone Oct 15, 2017
@ikedas
Copy link
Member

ikedas commented Oct 16, 2017

Merged. Thanks for correction!

@ikedas ikedas closed this as completed Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants