-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing malformed closing tags #776
Comments
I think, that should be possible today, because we do not check (yet. I plan to add optional To be clear, both should be recognized as |
It's literally possible to construct such an event, however there's no way to get the attributes from it unless you parse them yourself. Looking at the documentation for We do give an example of creating such an event (although I think this isn't a great idea because it is currently our only example - we should not have the only example provided be an instance of nonconformant XML). But in this example the entire string, including the attributes, is returned when you call |
We don't actually care about the attributes or anything else in the closing tag. I just found about the config option However Flash treats |
I know only one example which we do not support right now: </a foo=">"> will be parsed as Event::End(BytesEnd::new("a foo=\""));
Event::Text(BytesText::from_escaped("\">")); Do you need a mode that will parse this as Event::End(BytesEnd::new("a foo=\">\"")); ? |
Oh no. Flash does parse it ... var xml = new XML('<a></a foo=">">')
trace(xml.toXMLString()) // <a/> It does seem very unlikely to happen, so if that specific case would be very hard we might be able to skip it. |
No, that is simple to support. I think, we even may always parse this in such way, because anyway the tag name cannot contain neither |
With release 0.36.0 it is possible to parse such XMLs without surprises. |
For Ruffle it would be useful if we could parse these two kinds of malformed XML:
From ruffle-rs/ruffle#15674. Note the extra
/
.From ruffle-rs/ruffle#16862. Note the attribute in the closing tag!
Excuse me if I missed a config option for this.
The text was updated successfully, but these errors were encountered: